[Gluten-1.2] Port #10782 to Branch-1.2 for Release excessively reserved memory in HashBuild even if non-reclaimable (#10782) #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble (facebookincubator#10782) Summary: When hash build is under table building stage, we reserve excessive amount of memory to account for the worst case scenario duplicate rows for NextRowVector (i.e. we assume every row in build table has duplicates, which in most cases is not true). Other than let the query fail because the current stage is unreclaimable, we can perform a desperate try to release the unused reserved memory, giving the query a chance to succeed. Pull Request resolved: facebookincubator#10782 Reviewed By: xiaoxmeng Differential Revision: D61510068 Pulled By: tanjialiang fbshipit-source-id: 1d62804d22ab11d08080e7cf872da0656cbd1010 (cherry picked from commit 55888da)
|
@zhouyuan Can you help review this? |
zhztheplayer
approved these changes
Aug 27, 2024
|
The PR has run pass 333 velox tests with fail 1 test related to ParquetTableScanTest.timestampFilter test report empty parquet file. |
weiting-chen
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When hash build is under table building stage, we reserve excessive amount of memory to account for the worst case scenario duplicate rows for NextRowVector (i.e. we assume every row in build table has duplicates, which in most cases is not true). Other than let the query fail because the current stage is unreclaimable, we can perform a desperate try to release the unused reserved memory, giving the query a chance to succeed.
Pull Request resolved: facebookincubator#10782
Reviewed By: xiaoxmeng
Differential Revision: D61510068
Pulled By: tanjialiang
fbshipit-source-id: 1d62804d22ab11d08080e7cf872da0656cbd1010 (cherry picked from commit 55888da)